Adopt @microbit/eslint-config - #10
Merged
Merged
Conversation
Replaces the legacy .eslintrc.cjs and per-project plugin set with the shared flat config, moving to ESLint 9. As in makecode-embed, eslint-plugin-storybook stays a project dependency since its version tracks Storybook's release cycle. Fixes for the type-aware rules the shared config enables: - Type the frame driver listener's event.data, previously any, via a narrow local type the existing per-message casts build on. - Mark the intentionally unawaited handleWorkspaceSync call with void and drop async from initialProjects callbacks with no await. The lockfile is regenerated as npm could not resolve the ESLint major bump in place.
Deploying python-editor-embed with
|
| Latest commit: |
ee84ea4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://501ec7ec.python-editor-embed.pages.dev |
| Branch Preview URL: | https://shared-eslint-config.python-editor-embed.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the legacy .eslintrc.cjs and per-project plugin set with the shared flat config, moving to ESLint 9. As in makecode-embed, eslint-plugin-storybook stays a project dependency since its version tracks Storybook's release cycle.
Fixes for the type-aware rules the shared config enables:
The lockfile is regenerated as npm could not resolve the ESLint major bump in place.